Skip to content

Conversation

GantaRoja
Copy link
Collaborator

Replaced full path https://quantum.cloud.ibm.com with absolute link / #3663

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

One or more of the following people are relevant to this code:

Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Roja! 🙌

Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

<span id="from-runtime-cloud"></span>
## Migrate from the Qiskit Runtime on IBM Cloud REST API
If you are moving from the [Qiskit Runtime on IBM Cloud REST API](/docs/api/qiskit-runtime-rest), not much has changed for you. The following points are all you need to consider:
* When you call the API, instead of using `https://us-east.quantum-computing.cloud.ibm.com/` you must use: `https://quantum.cloud.ibm.com/api/`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL shouldn't be changed because is a code snippet

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentle bump on this URL

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you are not updating the docs/api folder, this file should be kept as it was. This is because all your changes were manually and not from the API generation script

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentle bump on this

"announcements/product-updates.mdx",
"announcements/index.mdx",
"announcements/product-updates/2025-03-03-new-version-dynamic-circuits.mdx",
"learning/index.mdx",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry is duplicated

"learning/index.mdx",
"functions.mdx",
"functions?id=qedma-qesem.mdx",
"index.mdx",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but this is not necessary anymore, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentle bump on this

<span id="from-runtime-cloud"></span>
## Migrate from the Qiskit Runtime on IBM Cloud REST API
If you are moving from the [Qiskit Runtime on IBM Cloud REST API](/docs/api/qiskit-runtime-rest), not much has changed for you. The following points are all you need to consider:
* When you call the API, instead of using `https://us-east.quantum-computing.cloud.ibm.com/` you must use: `https://quantum.cloud.ibm.com/api/`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentle bump on this URL

"computers?processorType=Heron.mdx",
"functions?id=q-ctrl-optimization-solver.mdx",
"scripts/js/lib/links/ignores.ts",
"./index.mdx", // This entry is for links to /
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be more permissive than we thought. For example, if a file in the root of the docs/ folder links to [index](./index), the link checker won't complain about it when it should. Have you explored any other solution? For example we could try mark links to / as always valid instead of having a synthetic file.

"login.mdx",
"composer.mdx",
"workloads.mdx",
"functions?id=multiverse-singularity.mdx",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to me previous comment, what do you think about stripping the query parameters from the links in the link checker? That way you will only need one entry for functions.mdx in this synthetic files list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants