-
Notifications
You must be signed in to change notification settings - Fork 141
Stop using external links to IQP #3663 #4032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…oja/StopUsimgExtLinksToIQP-3663
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 One or more of the following people are relevant to this code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Roja! 🙌
…oja/StopUsimgExtLinksToIQP-3663
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
<span id="from-runtime-cloud"></span> | ||
## Migrate from the Qiskit Runtime on IBM Cloud REST API | ||
If you are moving from the [Qiskit Runtime on IBM Cloud REST API](/docs/api/qiskit-runtime-rest), not much has changed for you. The following points are all you need to consider: | ||
* When you call the API, instead of using `https://us-east.quantum-computing.cloud.ibm.com/` you must use: `https://quantum.cloud.ibm.com/api/`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This URL shouldn't be changed because is a code snippet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle bump on this URL
learning/courses/utility-scale-quantum-computing/bits-gates-and-circuits.ipynb
Show resolved
Hide resolved
learning/courses/utility-scale-quantum-computing/quantum-circuit-optimization.ipynb
Outdated
Show resolved
Hide resolved
learning/courses/utility-scale-quantum-computing/quantum-circuit-optimization.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that you are not updating the docs/api
folder, this file should be kept as it was. This is because all your changes were manually and not from the API generation script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle bump on this
"announcements/product-updates.mdx", | ||
"announcements/index.mdx", | ||
"announcements/product-updates/2025-03-03-new-version-dynamic-circuits.mdx", | ||
"learning/index.mdx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry is duplicated
"learning/index.mdx", | ||
"functions.mdx", | ||
"functions?id=qedma-qesem.mdx", | ||
"index.mdx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct me if I'm wrong, but this is not necessary anymore, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle bump on this
<span id="from-runtime-cloud"></span> | ||
## Migrate from the Qiskit Runtime on IBM Cloud REST API | ||
If you are moving from the [Qiskit Runtime on IBM Cloud REST API](/docs/api/qiskit-runtime-rest), not much has changed for you. The following points are all you need to consider: | ||
* When you call the API, instead of using `https://us-east.quantum-computing.cloud.ibm.com/` you must use: `https://quantum.cloud.ibm.com/api/`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle bump on this URL
"computers?processorType=Heron.mdx", | ||
"functions?id=q-ctrl-optimization-solver.mdx", | ||
"scripts/js/lib/links/ignores.ts", | ||
"./index.mdx", // This entry is for links to / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be more permissive than we thought. For example, if a file in the root of the docs/
folder links to [index](./index)
, the link checker won't complain about it when it should. Have you explored any other solution? For example we could try mark links to /
as always valid instead of having a synthetic file.
"login.mdx", | ||
"composer.mdx", | ||
"workloads.mdx", | ||
"functions?id=multiverse-singularity.mdx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to me previous comment, what do you think about stripping the query parameters from the links in the link checker? That way you will only need one entry for functions.mdx
in this synthetic files list
Replaced full path https://quantum.cloud.ibm.com with absolute link / #3663